Skip to content

Bug: @typescript-eslint/only-throw-error False positive when throwing Error subclass #9882

Closed
@cowwoc

Description

@cowwoc

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.4.5&fileType=.mts&code=MYGwhgzhAEAqCmEAuxL2gbwLAChrQAcBXAIxAEthoB7AJ1gAtbqB3AHgFVp4APJeAHYATGAFFazWgD4AFPAl0AykQIEK8gFzQZASmgBeKdA57sefNGDUByaBGoBbeOMkHuC2stXraugNy4FtBITKx2js4eAeYAvrgxQA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6AeyfkNvwAto7AO71og6OiiIx7CeDABfEAqA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

class Testcase {
  public orThrow<U extends Error>(errorSupplier: () => U) {
    const someError = errorSupplier();
    throw someError;
  }
}

ESLint Config

{
  "rules": {
    "@typescript-eslint/only-throw-error": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

No warning

Actual Result

Expected an error object to be thrown @typescript-eslint/only-throw-error

Additional Info

const someError: U fails, but
const someError: Error passes.

Given that U extends Error I expect this to pass as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions