chore(widgets): Encapsulate the hacky / complex setViewState() #9596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
requested changes
Apr 23, 2025
| @@ -95,31 +92,6 @@ export class GeolocateWidget extends Widget<GeolocateWidgetProps> { | |||
| handleCoordinates = coordinates => { | |||
| this.setViewState(coordinates); | |||
Comment on lines
-102
to
-103
| const viewId = this.props.viewId || (viewState?.id as string) || 'default-view'; | ||
| const viewport = this.viewports[viewId] || {}; |
There was a problem hiding this comment.
This is necessary in widget that set view state
Comment on lines
-118
to
-122
| onViewportChange(viewport: Viewport) { | ||
| this.viewports[viewport.id] = viewport; | ||
| } | ||
|
|
||
| viewports: Record<string, Viewport> = {}; |
| @@ -61,18 +64,10 @@ export class ResetViewWidget extends Widget<ResetViewWidgetProps> { | |||
|
|
|||
| handleClick() { | |||
| const initialViewState = this.props.initialViewState || this.deck?.props.initialViewState; | |||
There was a problem hiding this comment.
We really ought to combine what this widget does and what compass widget does so that they can be used in either mode (initialViewState/viewState)
A user managing viewState would be able to use this widget too if we made homeViewState a widget prop, and stored viewports in the widget like the others.
In compass, we don't need to expose a prop but just check if initialViewState is in use.
| * @note this code abuses protected methods and should be refactored, | ||
| * but does work for now until we have a cleaner solutions. | ||
| */ | ||
| setViewState({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Background
For discussion
TODO -
Change List