fix: Token Response's Content-Type to application/json

mokemokechicken · bshaffer · commit 70e3b8d1ce42 · 2016-01-12T11:48:47.000-08:00
fix: at_hash digest computation('hash' function must be used with raw_output=true )
diff --git a/src/OAuth2/Controller/TokenController.php b/src/OAuth2/Controller/TokenController.php
@@ -51,7 +51,11 @@ public function handleTokenRequest(RequestInterface $request, ResponseInterface
             // server MUST disable caching in headers when tokens are involved
             $response->setStatusCode(200);
             $response->addParameters($token);
-            $response->addHttpHeaders(array('Cache-Control' => 'no-store', 'Pragma' => 'no-cache'));
+            $response->addHttpHeaders(array(
+                'Cache-Control' => 'no-store',
+                'Pragma' => 'no-cache',
+                'Content-Type' => 'application/json'
+            ));
         }
     }
 
diff --git a/src/OAuth2/OpenID/ResponseType/IdToken.php b/src/OAuth2/OpenID/ResponseType/IdToken.php
@@ -84,7 +84,7 @@ protected function createAtHash($access_token, $client_id = null)
         // maps HS256 and RS256 to sha256, etc.
         $algorithm = $this->publicKeyStorage->getEncryptionAlgorithm($client_id);
         $hash_algorithm = 'sha' . substr($algorithm, 2);
-        $hash = hash($hash_algorithm, $access_token);
+        $hash = hash($hash_algorithm, $access_token, true);
         $at_hash = substr($hash, 0, strlen($hash) / 2);
 
         return $this->encryptionUtil->urlSafeB64Encode($at_hash);

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,11 @@ public function handleTokenRequest(RequestInterface $request, ResponseInterface`
`51`	`51`	`// server MUST disable caching in headers when tokens are involved`
`52`	`52`	`$response->setStatusCode(200);`
`53`	`53`	`$response->addParameters($token);`
`54`		`- $response->addHttpHeaders(array('Cache-Control' => 'no-store', 'Pragma' => 'no-cache'));`
	`54`	`+ $response->addHttpHeaders(array(`
	`55`	`+ 'Cache-Control' => 'no-store',`
	`56`	`+ 'Pragma' => 'no-cache',`
	`57`	`+ 'Content-Type' => 'application/json'`
	`58`	`+ ));`
`55`	`59`	`}`
`56`	`60`	`}`
`57`	`61`