DEV: Add category_users converter and importer steps
#33367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds converter(Discourse-only, for now) and importer steps for `category_users`
github-actions
bot
added
the
migrations-tooling
s3lase
commented
Jun 27, 2025
Comment on lines
+34
to
+39
| @existing_category_users = Hash.new { |h, k| h[k] = Set.new } | ||
|
|
||
| @discourse_db | ||
| .query_array("SELECT category_id, user_id FROM category_users WHERE user_id >= 0") | ||
| .each { |row| @existing_category_users[row[0]].add(row[1]) } | ||
|
|
There was a problem hiding this comment.
I wasn’t too happy with the string concatenation approach I used here and here, so I did some testing and benchmarking. This new approach is about 1.8x faster and avoids allocating new strings for each row during lookups.
I think we should elevate this pattern it to a macro, but there are a few things I'd like to work through first:
- Should this be a new macro? Or should we extend
requires_mapto support this via a config? - What about
requires_set? I'm not sure, it feels like it would add unnecessary overhead won't be intuitive in it's current form - Should it just return a set of arrays?
- What happens to hierarchically scoped keys when there are more than two columns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds converter(Discourse-only, for now) and importer steps for
category_users