FIX: Show tip for required selectable field on signup when not selected #33401
+43
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropdown and multiselect components lack `InputTip`, which makes them not show any reason when validation fails. This commit also adds a new i18n message for select fields, after this commit, if a multiselect or dropdown custom field required has no option selected, it will display a `Please select a value for "XX" field` validation error when the Signup button is clicked.
github-actions
bot
added
the
i18n
Lhcfl
changed the title
nattsw
reviewed
Jul 1, 2025
| @@ -3309,7 +3310,7 @@ en: | |||
| hot: "There are no hot topics." | |||
| filter: "There are no topics." | |||
| education: | |||
| topic_tracking_preferences: "You can view and change your new topic tracking settings in <a href=\"%{basePath}/my/preferences/tracking\">your preferences</a>." | |||
| topic_tracking_preferences: 'You can view and change your new topic tracking settings in <a href="%{basePath}/my/preferences/tracking">your preferences</a>.' | |||
There was a problem hiding this comment.
I think you can undo the change here in this PR since it’s unrelated and no difference. (though it is better imo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropdown and multiselect components lack
InputTip, which makes them not show any reason when validation fails.This commit also adds a new i18n message for select fields, after this commit, if a multiselect or dropdown custom field required has no option selected, it will display a
Please select a value for "XX" fieldvalidation error when the Signup button is clicked.Screenshot