FIX: Use SolvedTopics to list posts in /activity/solved instead of user actions #376
Conversation
| @body={{@controller.model.emptyState.body}} | ||
| /> | ||
| {{else}} | ||
| <UserStream @stream={{@controller.model.stream}} /> |
There was a problem hiding this comment.
SolvedPostsStream is being passed into UserStream, and I can see a couple of places (for e.g. https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/components/user-stream.gjs#L50) there which expect the stream to have a remove method. For this context, would those methods be called?
(from the vids, doesn't seem like there's available interactions that will result in removal of bookmarks/drafts, but thought it's worth clarifying).
There was a problem hiding this comment.
Yeah there isn't a need to remove a solution.
| export default class UserActivitySolved extends UserActivityStreamRoute { | ||
| userActionType = 15; | ||
| noContentHelpKey = "solved.no_solutions"; | ||
| class SolvedPostsStream extends EmberObject { |
There was a problem hiding this comment.
Does this need to be an EmberObject? I think this could work as a lighter weight native class since we are already making use of @tracked to make this reactive and I didn't see anything in UserStream that relies onthe stream being an EmberObject.
In #342 we moved solutions away from topic_custom_fields into proper tables, with the tables as the proper source of truth to a topic's solution.
The user's /my/activity/solved route uses user_actions which is not accurate, and a user has reported a bug where their solution is not reflected there (user actions are not a good representation of what a topic's solution is).
This PR introduces
hide_user_profiles_from_publicand such settings<UserStream>to load posts safely and avoid reimplementationAfter fix:
Screen.Recording.2025-06-27.at.12.21.23.PM.mov
Screen.Recording.2025-06-26.at.5.34.33.PM.mov