Skip to content

Do not expand keys which have have already been expanded #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

dratchkov
Copy link

This avoid issues when model relations have a semi-cyclical structure

@coveralls
Copy link

coveralls commented May 5, 2016

Coverage Status

Coverage decreased (-14.6%) to 79.459% when pulling 4ff3e3b on dratchkov:master into ed1b233 on django-cache-machine:master.

@tobiasmcnulty
Copy link
Member

Hi @dratchkov , apologies for the long delay on this. Is this still something you're interested in getting in? If so, what was the issue you ran into with cyclical models that made this necessary (and could you include a test for it)?

Please note the project (finally!) has been updated to Django 1.11 and that required some internal refactoring, so you will need to rebase this PR if you do decide to update it.

@tobiasmcnulty
Copy link
Member

Please note, #120 purports to be an alternative (and simpler) implementation for this issue.

@dratchkov
Copy link
Author

I created #127 to supersede this pull request.

@dratchkov dratchkov closed this Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants