Skip to content

ENH: errorbar in qt figureoptions #18650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ENH: errorbar in qt figureoptions #18650

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72e9c8c
ENH: errorbar in qt figureoptions
andyfaff Oct 4, 2020
a03e224
MAINT: refactor flatten
andyfaff Oct 10, 2020
db84f5f
MAINT: figureoptions restrict to errorbar
andyfaff Oct 12, 2020
683caf6
MAINT: cbook.flatten
andyfaff Oct 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 38 additions & 3 deletions lib/matplotlib/backends/qt_editor/figureoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from matplotlib import cbook, cm, colors as mcolors, markers, image as mimage
from matplotlib.backends.qt_compat import QtGui
from matplotlib.backends.qt_editor import _formlayout
from matplotlib.container import ErrorbarContainer


LINESTYLES = {'-': 'Solid',
Expand Down Expand Up @@ -65,13 +66,23 @@ def cmp_key(label):
else:
return label, 0

# Get / Curves
# Obtain all the lines and Curves displayed on the plot
linedict = {}
for line in axes.get_lines():
label = line.get_label()
if label == '_nolegend_':
continue
linedict[label] = line

# Obtain errorbar plots, which are in containers
# TODO: bar charts?
for container in axes.containers:
label = container.get_label()
if label == '_nolegend_':
continue
elif isinstance(container, ErrorbarContainer):
# don't do anything but ErrorbarContainers to start with
linedict[label] = container
curves = []

def prepare_data(d, init):
Expand Down Expand Up @@ -103,7 +114,13 @@ def prepare_data(d, init):

curvelabels = sorted(linedict, key=cmp_key)
for label in curvelabels:
line = linedict[label]
o = linedict[label]
if isinstance(o, ErrorbarContainer):
# we'll change the bar/caps properties of the errorbar plot based
# on the properties of the host line
line = o[0]
else:
line = o
color = mcolors.to_hex(
mcolors.to_rgba(line.get_color(), line.get_alpha()),
keep_alpha=True)
Expand Down Expand Up @@ -205,7 +222,12 @@ def apply_callback(data):

# Set / Curves
for index, curve in enumerate(curves):
line = linedict[curvelabels[index]]
o = linedict[curvelabels[index]]
if isinstance(o, ErrorbarContainer):
# we'll change the host line of the errorbar plot first
line = o[0]
else:
line = o
(label, linestyle, drawstyle, linewidth, color, marker, markersize,
markerfacecolor, markeredgecolor) = curve
line.set_label(label)
Expand All @@ -221,6 +243,19 @@ def apply_callback(data):
line.set_markerfacecolor(markerfacecolor)
line.set_markeredgecolor(markeredgecolor)

if isinstance(o, ErrorbarContainer):
# now adjust bar/caps of errorbar plot based on changed
# characteristics of the host line
# We'll only do color to start with, make it the same color as
# the marker, because the errorbar is closely associated with
# it.
# TODO: adjust other characteristics of the errorbars? This
# will involve adjusting the Qt dialog.
for line in cbook.flatten(o[1:]):
line.set_alpha(None)
line.set_color(markerfacecolor)
line.set_linewidth(linewidth)

# Set ScalarMappables.
for index, mappable_settings in enumerate(mappables):
mappable = mappabledict[mappablelabels[index]]
Expand Down