add VM Lock around rb_const_remove operations (Module#remove_const)
#13717
+99
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a VM Lock, there's an unlocked `rb_id_table_delete` for the
class's const_tbl which can cause problems. Example:
```ruby
class C
CONSTANT = 3
end
$VERBOSE = nil
rs = []
100.times do
rs << Ractor.new do
10_000.times do
if defined?(C::CONSTANT)
C.send(:remove_const, :CONSTANT) rescue NameError
else
C.send(:const_set, :CONSTANT, 3)
end
end
end
end
while rs.any?
r, obj = Ractor.select(*rs)
rs.delete(r)
end
```
Without lock:
../ruby-release/test.rb:14: [BUG] Segmentation fault at 0x0000000000000001
-- Control frame information -----------------------------------------------
miniruby(82790,0x16f49f000) malloc: *** error for object 0x600000f880a0: pointer being freed was not allocated
miniruby(82790,0x16f49f000) malloc: *** set a breakpoint in malloc_error_break to debug
|
Seems like we might be missing locking for const lookup as well. class C
CONSTANT = 3
end
$VERBOSE = nil
rs = []
100.times do
rs << Ractor.new do
10_000.times do
if defined?(C::CONSTANT)
C.send(:remove_const, :CONSTANT) rescue NameError
else
C.send(:const_set, :CONSTANT, 3)
end
C.const_get(:CONSTANT) rescue NameError
C.const_get(:CONSTANT) rescue NameError
end
end
end
while rs.any?
r, obj = Ractor.select(*rs)
rs.delete(r)
end |
|
Should |
|
Yeah it's a good point, but for whatever reason this has always been allowed in ractors, and it was by design not by accident. As for why, I don't know but maybe it's to do with supporting autoloading in ractors. If you support autoloading constants, it's a small step away from supporting setting constants directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a VM Lock, there's an unlocked
rb_id_table_deletefor the class's const_tbl which can cause problems. Example:Without lock:
../ruby-release/test.rb:14: [BUG] Segmentation fault at 0x0000000000000001 -- Control frame information ----------------------------------------------- miniruby(82790,0x16f49f000) malloc: *** error for object 0x600000f880a0: pointer being freed was not allocated miniruby(82790,0x16f49f000) malloc: *** set a breakpoint in malloc_error_break to debug