Skip to content

Fix Rubocop Offenses #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 3, 2025
Merged

Fix Rubocop Offenses #818

merged 19 commits into from
Jul 3, 2025

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Jul 3, 2025

Manually fix Rubocop offenses from the TODO file.

jcouball added 4 commits July 2, 2025 18:11
The Branch, Remote, and Worktree classes all inherit from Path
but do not initialize it. Rather than call super, I am removing the
inheritance. While this could be considered a breaking change,
since the base class was never initialized, objects of these
classes can not make use of the Path methods.
@jcouball jcouball force-pushed the duplicate_methods branch from 869e788 to 1f94cf4 Compare July 3, 2025 16:11
@jcouball jcouball force-pushed the duplicate_methods branch from c2564d0 to fd437a6 Compare July 3, 2025 18:02
@jcouball jcouball merged commit 52d80ac into main Jul 3, 2025
7 checks passed
@jcouball jcouball deleted the duplicate_methods branch July 3, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant