Will this also fix #39588?

Will this also fix #39588?

Yes it will !

To describe more in depth the behavior of this PR, let's take these controllers

• src/Controller/Foo/BarController
• src/Controller/DebugController
• src/Controller/DebugFooController
• src/Controller/HelloController

The following configurations will exclude DebugController and DebugFooController

# config/routes/annotations.yaml

controllers:
    resource: '../../src/Controller/'
    type: annotation
    exclude: '../../src/Controller/{Debug*Controller.php}'

# or

controllers:
    resource: '../../src/Controller/**/*'
    type: annotation
    exclude: '../../src/Controller/{Debug*Controller.php}'

And the following configuration will exclude DebugController, DebugFooController and Foo\BarController:

# config/routes/annotations.yaml
controllers:
    resource: '../../src/Controller/*'
    type: annotation
    exclude: '../../src/Controller/{Debug*Controller.php}'

Hello,

Unfortunately, I realized the following exclude condition will not work in version 6.4:

controllers:
    resource:
        path: ../src/Controller/
        namespace: App\Controller
    exclude: '../src/Controller/{Debug*Controller.php}'
    type: attribute

This declaration will be handled by the Symfony\Component\Routing\Loader\Psr4DirectoryLoader, which hasn't access to the exclude parameter.

After digging a little deeper, I have the feeling there is a bad design here. In an ideal world each loader will have access to this exclude parameter, and deal with it to load or not their routes. But adding such a big change will involve some BC break...

What do you think guys ?