[Intl] Remove deprecated EmojiTransliterator
#60986
Open
+11
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mttsch
commented
Jun 30, 2025
mttsch
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
mttsch
force-pushed
the
feature/EmojiTransliterator
branch
from
6a6e0eb to
5ac3ea2
Compare
|
Symfony docs do not need an update because they already use class from the emoji component. |
mttsch
force-pushed
the
feature/EmojiTransliterator
branch
from
5ac3ea2 to
009248d
Compare
OskarStark
reviewed
Jun 30, 2025
mttsch
force-pushed
the
feature/EmojiTransliterator
branch
from
009248d to
b01708b
Compare
OskarStark
approved these changes
Jun 30, 2025
mttsch
changed the title
EmojiTransliterator
mttsch
force-pushed
the
feature/EmojiTransliterator
branch
from
b01708b to
ebfd7a8
Compare
xabbuh
reviewed
Jul 1, 2025
| Intl | ||
| ---- | ||
|
|
||
| * Remove `Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use `Symfony\Component\Emoji\EmojiTransliterator` instead |
There was a problem hiding this comment.
Suggested change
| * Remove `Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use `Symfony\Component\Emoji\EmojiTransliterator` instead | |
| * Remove `EmojiTransliterator`, use `Symfony\Component\Emoji\EmojiTransliterator` instead |
There was a problem hiding this comment.
I asked explicitly for the FQCN, as I find it hard to spot the difference, as the classname stays the same
There was a problem hiding this comment.
@xabbuh @OskarStark Can you discuss the issue among yourselves and then tell me which one is the final one I should use. I like to avoid going back and forth unnecessarily :)
xabbuh
reviewed
Jul 1, 2025
| 8.0 | ||
| --- | ||
|
|
||
| * Remove `Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use `Symfony\Component\Emoji\EmojiTransliterator` instead |
There was a problem hiding this comment.
Suggested change
| * Remove `Symfony\Component\Intl\Transliterator\EmojiTransliterator`, use `Symfony\Component\Emoji\EmojiTransliterator` instead | |
| * Remove `EmojiTransliterator`, use `Symfony\Component\Emoji\EmojiTransliterator` instead |
stof
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.