[TypeInfo] Remove deprecated code for non-array based collections #60988
Conversation
mttsch
commented
Jun 30, 2025
mttsch
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
I could not find a reference to the removed code in Symfony docs, thus I do not think they need updates. Also see the docs issue for the deprecations: symfony/symfony-docs#20602 |
mtarld
changed the title
mttsch
force-pushed
the
feature/type_info_array_collection
branch
from
042d3f7 to
d522388
Compare
| ```diff | ||
| use Symfony\Component\TypeInfo\Type; | ||
|
|
||
| -$type = Type::iterable(Type::string(), asList: true); | ||
| +$type = Type::list(Type::string()); | ||
| ``` |
There was a problem hiding this comment.
We usually don't put diffs in changelogs 🙂
There was a problem hiding this comment.
I am sorry, but I am getting really mixed signals. In another PR, the UPGRADE contains before/after examples, the CHANGELOG did not. There it is suggested (by a Symfony Core Member) to also add before/after examples to the CHANGELOG. In this PR, it is suggested, to not do it.
I am happy to do the changes, but it appears that - unless I am misunderstanding things - there seems to be no consensus on this topic 🙂
There was a problem hiding this comment.
I don't think this example is necessary tbh, the sentance is self-sufficient to me. Anyway I'd say diffs are cool for CHANGELOGs as well as UPGRADE files :)
