Skip to content

[JsonStreamer] Fix nested generated foreach loops #61001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
from
Open

[JsonStreamer] Fix nested generated foreach loops #61001

wants to merge 1 commit into from
+168 −32

Conversation

mttsch
Copy link
Contributor

@mttsch mttsch commented Jul 1, 2025

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60984
License MIT

@carsonbot carsonbot added this to the 7.3 milestone Jul 1, 2025
@mttsch mttsch mentioned this pull request Jul 1, 2025
Open
mtarld
mtarld requested changes Jul 1, 2025
View reviewed changes
@mttsch mttsch force-pushed the bugfix/JsonStreamer-nested-loop branch from 769c229 to 89887a8 Compare July 1, 2025 15:08
@mttsch
Copy link
Contributor Author

mttsch commented Jul 1, 2025 •
edited
Loading

@mtarld Except for the constructor property promotion comment (see my response above), your notes have been implemented.

mtarld
mtarld reviewed Jul 1, 2025
View reviewed changes
@mttsch mttsch force-pushed the bugfix/JsonStreamer-nested-loop branch from 89887a8 to 6c97b1d Compare July 1, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtarld mtarld mtarld approved these changes

Assignees
No one assigned
Labels
Bug JsonStreamer Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mttsch @mtarld @carsonbot