[TypeInfo] Reuse CollectionType::mergeCollectionValueTypes for ConstFetchNode
#61014
+6
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
norkunas
commented
Jul 1, 2025
norkunas
commented
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | #60820 (comment) |
| License | MIT |
mtarld
reviewed
Jul 1, 2025
| yield [Type::null(), DummyWithConstants::class.'::DUMMY_NULL_*']; | ||
| yield [Type::array(), DummyWithConstants::class.'::DUMMY_ARRAY_*']; | ||
| yield [Type::array(null, Type::union(Type::int(), Type::string())), DummyWithConstants::class.'::DUMMY_ARRAY_*']; |
There was a problem hiding this comment.
Suggested change
| yield [Type::array(null, Type::union(Type::int(), Type::string())), DummyWithConstants::class.'::DUMMY_ARRAY_*']; | |
| yield [Type::array(key: Type::union(Type::int(), Type::string())), DummyWithConstants::class.'::DUMMY_ARRAY_*']; |
Is a bit more explicit to me 🙂
There was a problem hiding this comment.
i was done like that before, but something popped in my mind that symfony does not use named params 🤷♂️
There was a problem hiding this comment.
named parameters are not covered by our BC promise (except in attribute constructors). And we want our tests to use our API covered by BC guarantees, as it allows to catch mistakes where we break BC (if we have to update tests, it is a good indication that something changed that might not be intended).
Comment on lines
+106
to
+107
| yield [Type::true(), DummyWithConstants::class.'::DUMMY_TRUE_*']; | ||
| yield [Type::false(), DummyWithConstants::class.'::DUMMY_FALSE_*']; |
There was a problem hiding this comment.
This needs to be backported to 7.2 IMO.
There was a problem hiding this comment.
yes, will do that afterwards :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.