Skip to content

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-unused-expressions.test.ts #11347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2025
Merged

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-unused-expressions.test.ts #11347

merged 3 commits into from
Jul 6, 2025
+120 −111

Conversation

Vinccool96
Copy link
Contributor

@Vinccool96 Vinccool96 commented Jun 26, 2025 •
edited by kirkwaiblinger
Loading

PR Checklist

Overview

  • Added the messageId of eslint
  • Change dynamic test cases using spread and map to handwritten ones
  • No existing recurring cases exist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 26, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1438ffd
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/686af3fa29c06b00080d5565
😎 Deploy Preview https://deploy-preview-11347--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1438ffd

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 19s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 6s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-06 22:14:37 UTC

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean as usual and with a message ID cleanup. Very lovely. Thanks! 🥇

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 30, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) July 6, 2025 21:11
@kirkwaiblinger kirkwaiblinger merged commit 1ca81c1 into typescript-eslint:main Jul 6, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Change the messageId to match eslint Repo: [no-unused-expressions.test.ts] Switch auto-generated test cases to hand-written
3 participants
@Vinccool96 @JoshuaKGoldberg @kirkwaiblinger