Skip to content

chore: try branch with environment main set #11366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025
+13 −4
Merged

chore: try branch with environment main set #11366

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
984ae67
chore: try branch with environment main set
JamesHenry Jul 1, 2025
cdf5314
chore: try inline conditional environment
JamesHenry Jul 1, 2025
4d3e712
chore: environment config for each job, clarify NPM_TOKEN
JamesHenry Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ concurrency:

env:
PRIMARY_NODE_VERSION: 20
# Value will be controlled via main environment secret, will be read-write for main branch, read-only for other branches
GITHUB_ENVIRONMENT: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }}
# Value will be controlled via GitHub environment (called "main") secret, will be read-write for main branch, read-only for other branches
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
# This increases the verbosity of the logs for everything, including Nx Cloud, but will hopefully surface more info about recent lint failures
NX_VERBOSE_LOGGING: false
Expand All @@ -39,7 +38,7 @@ permissions:
jobs:
install:
name: Checkout and Install
environment: 'main'
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
runs-on: ubuntu-latest
env:
NX_CI_EXECUTION_ENV: 'ubuntu-latest'
Expand All @@ -53,7 +52,7 @@ jobs:

build:
name: Build All Packages
environment: 'main'
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [install]
runs-on: ubuntu-latest
env:
Expand All @@ -70,6 +69,7 @@ jobs:

generate_configs:
name: Generate Configs
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [build]
runs-on: ubuntu-latest
env:
Expand All @@ -88,6 +88,7 @@ jobs:

lint_without_build:
name: Lint without build
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [install]
runs-on: ubuntu-latest
strategy:
Expand All @@ -108,6 +109,7 @@ jobs:

lint_with_build:
name: Lint with build
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
# because we lint with our own tooling, we need to build
needs: [build]
runs-on: ubuntu-latest
Expand All @@ -133,6 +135,7 @@ jobs:

stylelint:
name: Stylelint
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [install]
runs-on: ubuntu-latest
env:
Expand All @@ -150,6 +153,7 @@ jobs:

integration_tests:
name: Run integration tests on primary Node.js version
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [build]
runs-on: ubuntu-latest
env:
Expand All @@ -171,6 +175,7 @@ jobs:

unit_tests:
name: Run Unit Tests
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [build]
runs-on: ${{ matrix.os }}
strategy:
Expand Down Expand Up @@ -236,6 +241,7 @@ jobs:

unit_tests_project_service:
name: Run Unit Tests with Project Service
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [build]
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -264,6 +270,7 @@ jobs:

upload_coverage:
name: Upload Codecov Coverage
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
needs: [unit_tests]
runs-on: ubuntu-latest
steps:
Expand All @@ -285,6 +292,7 @@ jobs:

publish_canary_version:
name: Publish the latest code as a canary version
environment: ${{ (github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main') && 'main' || '' }} # Have to specify per job
runs-on: ubuntu-latest
permissions:
id-token: write
Expand Down Expand Up @@ -313,5 +321,6 @@ jobs:
run: npx nx release publish --tag canary --verbose
env:
NX_CLOUD_DISTRIBUTED_EXECUTION: false
# This secret is only accessible on the GitHub environment "main"
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_CONFIG_PROVENANCE: true