Skip to content

ICU-23120 Fix malloc request larger than PTRDIFF_MAX bytes #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-23120 Fix malloc request larger than PTRDIFF_MAX bytes #3496

wants to merge 1 commit into from

Conversation

SoapGentoo
Copy link

@SoapGentoo SoapGentoo commented May 16, 2025 •
edited
Loading

only run UnicodeStringTest::TestLargeMemory() on 64-bit platforms

Checklist

  • Required: Issue filed: ICU-23120
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented May 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aheninger
aheninger reviewed May 21, 2025
View reviewed changes
@markusicu markusicu self-assigned this May 22, 2025
@SoapGentoo SoapGentoo force-pushed the ICU-23120-PTRDIFF_MAX-malloc branch from a0d280e to 4b3e688 Compare June 21, 2025 10:28
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/intltest/ustrtest.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheninger aheninger aheninger left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SoapGentoo @CLAassistant @aheninger @markusicu