Notice: the branch changed across the force-push!

• .github/workflows/icu4j.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

For review purposes and consideration:

• There are 2 commits in the PR: one has the key config changes and doc updates, and the other has the changes to the remaining codebase Java source files
• Let's decouple the work of reviewing/approving from the action of actually merging the PR, and not assume that we do these things at the same time for this PR
• When this gets merged, then any concurrent open PRs that touch Java files will need to update themselves with the latest on main to pick up the new source formatting. That will cause churn. We can choose the right time to merge. Of course, likewise, this PR will need to pick up the latest from main for any Java changes between now and when we actually merge

@yumaoka @richgillam FYI

• thanks!
• what about the 11 failing ("cancelled") checks?
• config looks plausible
• code reformatting changes... I know not to quibble with the formatter...
• we will need to talk about when to merge this
• we might want to push everyone (mea culpa etc.) to move on pending pull requests and reviews, so that there are fewer pending when this goes in

• what about the 11 failing ("cancelled") checks?

I retried them and all but one succeeded. The ones that passed after retrying were all from the ICU4C CI workflow, and given that this PR here is only about source code formatting for Java, it's safe to conclude that those ICU4C check failures during the first attempt are unrelated. The other check that failed is the "meta check" job called "Wait for Required Checks", and it fails because the single-commit check fails. For now, I am leaving the two commits in the PR to remain separate in order to make it easier to understand when reviewing.

The other check that failed is the "meta check" job called "Wait for Required Checks", and it fails because the single-commit check fails. For now, I am leaving the two commits in the PR to remain separate in order to make it easier to understand when reviewing.

We should add the magic incantation that allows us to rebase+merge the two commits.

We should add the magic incantation that allows us to rebase+merge the two commits.

Done.