Skip to content

ICU-23137 Update CLDR data from HEAD #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-23137 Update CLDR data from HEAD #3528

wants to merge 1 commit into from

Conversation

grhoten
Copy link
Member

@grhoten grhoten commented Jun 19, 2025 •
edited
Loading

This is what I get when I build from HEAD for both CLDR and ICU.

These are the current failures. The RBNF issues observed in #3526 were not noticed.

| ***     FAILING TEST SUMMARY FOR:              intltest  
         TestPatterns
      DateFormatTest
         TestParseCurrencyInUCurr
      NumberFormatTest
         TestJapanese
         TestJapaneseFormat
      IntlCalendarTest
         test20640_HourCyclArsEnNH
      IntlTestDateTimePatternGeneratorAPI
         testFormat
         testTicket20707
         testHourMetacharacters
         testTicket21939
      DateIntervalFormatTest
   format
| *** END FAILING TEST SUMMARY FOR:              intltest

Checklist

  • Required: Issue filed: ICU-23137
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

grhoten
grhoten commented Jun 19, 2025
View reviewed changes
icu4c/source/data/rbnf/pl.txt
@@ -6,7 +6,7 @@ pl{
SpelloutRules{
"%spellout-numbering-year:",
"x.x: =0.0=;",
"0: =%spellout-numbering=;",
"0: =%spellout-ordinal-masculine-genitive=;",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes in this file are expected it's newly contributed data.

icu4c/source/data/rbnf/ga.txt
@@ -9,7 +9,7 @@ ga{
"60/60: <%%min<[, >>];",
"3600/60: <%%hr<[, >>>];",
"%%min:",
"0: =0= n\u00C3\u00B3im\u00C3\u00A9ad;",
"0: =0= n\u00F3im\u00E9ad;",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a typo that Markus noted during the code review of my latest changes. This change is expected.

@grhoten grhoten mentioned this pull request Jun 20, 2025
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedberg-icu pedberg-icu Awaiting requested review from pedberg-icu

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

@markusicu markusicu Awaiting requested review from markusicu

At least 1 approving review is required to merge this pull request.

Assignees

@DraganBesevic DraganBesevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grhoten @DraganBesevic