Skip to content

Fixed safe email formatting #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fixed safe email formatting #17

merged 1 commit into from
Dec 1, 2020

Conversation

krsriq
Copy link
Contributor

@krsriq krsriq commented Dec 1, 2020

Currently there's a formatting bug in the docs here: https://fakerphp.github.io/formatters/internet/#email
This PR should fix it.

@bram-pkg bram-pkg self-requested a review December 1, 2020 15:20
bram-pkg
bram-pkg approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@bram-pkg bram-pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess my column selection mode messed up here, thanks!

@bram-pkg bram-pkg merged commit 47f8a6e into FakerPHP:main Dec 1, 2020
@krsriq krsriq deleted the fix_safe_email_formatting branch December 1, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krsriq @bram-pkg