-
Notifications
You must be signed in to change notification settings - Fork 98
add en_SG documentation #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A lot of these things are already in core docs isnt it? Try only to document the locale specific |
@pimjansen Not really:
Basically most of these methods are added because it is possible to distinguish between mobile and landline numbers in Singapore. |
EnUS is also not core, see the root providers |
@pimjansen The documentation is always using |
Couldn't find any providers that have public If we document |
@krsriq Thank you for your suggestion. I've removed non-important methods documentation and left only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR adds missing documentation for English (Singapore) -
en_SG
providers.