chore(ci): cleanup prompt resources #13458
Conversation
product-auto-label
bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the cleanliness and efficiency of the CI environment by ensuring that temporary prompt resources created during automated tests are properly deleted. This addresses potential resource accumulation and contributes to more reliable and repeatable test runs, fixing an issue related to prompt resource management.
Highlights
- Resource Cleanup: Implemented automatic deletion of prompts created during
test_prompt_createandtest_prompt_getto prevent resource leakage in the test environment. - Test Environment Hygiene: Added logic to iterate and delete all prompts listed by
test_prompt_list_version, ensuring a clean state after test execution.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces necessary cleanup steps for prompt resources created during tests, which is crucial for maintaining a clean CI environment and preventing resource leaks. However, the cleanup logic in test_prompt_list_version is inefficient and potentially problematic as it attempts to delete the same prompt resource multiple times. A single delete call is sufficient for the prompt created by list_prompt_version.
| for prompt in list_versions: | ||
| prompts.delete(prompt_id = prompt.prompt_id) |
There was a problem hiding this comment.
The list_prompt_version function in prompt_list_version.py creates a single prompt and then lists its versions. All PromptMetadata objects returned by prompts.list_versions will share the same prompt_id. Therefore, iterating through list_versions and calling prompts.delete(prompt_id=prompt.prompt_id) for each item will attempt to delete the same prompt resource multiple times. This is inefficient and could lead to errors if the API does not handle redundant delete calls gracefully. A single call to prompts.delete using the prompt_id from any of the listed versions is sufficient to clean up the resource.
prompts.delete(prompt_id = list_versions[0].prompt_id)
Description
Fixes #13457