Skip to content

fix: Update the default model name for the ranking api default name #13472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

Puebster
Copy link
Contributor

The naming convention for the ranking api changed to:

  • semantic-ranker-default@latest

This PR updates the default model name.

For more information see:
https://cloud.google.com/generative-ai-app-builder/docs/ranking

Description

Fixes #13471

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

The naming convention for the ranking api changed to:
- semantic-ranker-default@latest

This PR updates the default model name.

For more information see:
https://cloud.google.com/generative-ai-app-builder/docs/ranking
@Puebster Puebster requested review from a team as code owners June 30, 2025 17:53
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: discoveryengine Issues related to the Discovery Engine API API. labels Jun 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Puebster, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default model name used by the ranking API to align with the latest naming conventions. This change ensures that the application uses the correct model when making ranking requests.

Highlights

  • Model Name Update: The default model name for the ranking API has been updated from semantic-ranker-512@latest to semantic-ranker-default@latest.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default model name for the ranking API in a sample file. The change is straightforward and aligns with the updated naming convention mentioned in the description. The code is correct and adheres to the project's style. I have no further comments.

@holtskinner holtskinner changed the title Update the default model name for the ranking api default name fix: Update the default model name for the ranking api default name Jul 1, 2025
@holtskinner
Copy link
Contributor

@iennae The test failures aren't related to this sample, and will require recreating some deleted resources in the test project. I don't have bandwidth to re-create these at this time, can you override and merge this PR?

@iennae iennae merged commit a379731 into main Jul 1, 2025
12 of 14 checks passed
@iennae iennae deleted the update-ranking-api-default-model-name branch July 1, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: discoveryengine Issues related to the Discovery Engine API API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default model of the ranking api has changed and needs to be updated.
3 participants