Skip to content

fix(core): Improved css clip-path parsing #10753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

fix(core): Improved css clip-path parsing #10753

merged 1 commit into from
Jun 30, 2025

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Jun 29, 2025 •
edited by coderabbitai bot
Loading

PR Checklist

What is the current behavior?

Right now, there are times that users update css clip-path property and do things like accidentally append semi-colon.
For example:

view.style.clipPath = "circle(50 at 0 100);"; // wrong
view.style.clipPath = "circle(50 at 0 100)"; // right

What is the new behavior?

This PR makes sure parser will ignore everything after the closing parenthesis.

Fixes/Closes #10717

Summary by CodeRabbit

  • Bug Fixes
    • Improved the handling of clip-path CSS function strings to ensure more accurate parsing and error checking.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 29, 2025 •
edited
Loading

Walkthrough

The parseClipPath function in style-properties.ts was refactored to improve parsing of CSS clip-path function strings. Variable names were clarified, and logic was updated to ensure both opening and closing parentheses are present before extracting the function arguments, enhancing error handling for malformed input.

Changes

File(s) Change Summary
packages/core/ui/styling/style-properties.ts Refactored parseClipPath function: improved variable naming and logic for parenthesis handling

Assessment against linked issues

Objective Addressed Explanation
Prevent app crash and throw exception for malformed clip-path strings (#10717) ✅

Poem

A bunny with code on its mind,
Fixed a bug of the parsing kind.
Parentheses checked,
So errors are wrecked—
Now clip-paths behave, well-defined!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-29T20_57_59_923Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a18370 and b27c6ce.

📒 Files selected for processing (1)
  • packages/core/ui/styling/style-properties.ts (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/core/ui/styling/style-properties.ts (1)
packages/core/ui/styling/clip-path-function.ts (1)
  • ClipPathFunction (8-39)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: test-ios
  • GitHub Check: test-android
🔇 Additional comments (1)
packages/core/ui/styling/style-properties.ts (1)

203-229: LGTM! Excellent improvement to clip-path parsing robustness.

The refactored logic correctly addresses the PR objective by using lastIndexOf(')') to find the closing parenthesis and substring(funcStartIndex + 1, funcEndIndex) to extract only the content between parentheses. This effectively ignores any trailing characters (like semicolons) after the closing parenthesis, making the parser more resilient to user input errors.

The implementation improvements:

  • Uses lastIndexOf(')') to reliably find the function's closing parenthesis
  • Validates both opening and closing parentheses exist before processing
  • Extracts content strictly between parentheses, ignoring trailing characters
  • Maintains existing error handling for invalid function names
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b27c6ce.

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 5m 31s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-29 21:04:47 UTC

@NathanWalker NathanWalker merged commit 32f2dd1 into NativeScript:main Jun 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android 8.9 error on clip-path
2 participants
@CatchABus @NathanWalker