Skip to content

Remove macos skips #5794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

Remove macos skips #5794

merged 1 commit into from
Jun 15, 2025

Conversation

arihant2math
Copy link
Collaborator

@arihant2math arihant2math commented May 19, 2025 •
edited by coderabbitai bot
Loading

Could not reproduce on an arm mac.

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to remove macOS-specific test skips. MacOS test runs now only exclude platform-independent tests, aligning test execution across platforms.

@youknowone
Copy link
Member

the test was hanging

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 15, 2025 •
edited
Loading

Walkthrough

The CI workflow configuration was updated to remove the MACOS_SKIPS environment variable and its usage. Now, macOS test runs do not skip any additional tests beyond the platform-independent ones, simplifying the test exclusion logic for macOS in the workflow.

Changes

File(s) Change Summary
.github/workflows/ci.yaml Removed MACOS_SKIPS environment variable and its usage in test steps

Poem

A hop through the CI, so spry and neat,
No more skips for Mac beneath our feet.
The tests now run with fewer rules,
Streamlined steps, no extra tools.
With every leap, our code feels light—
Hopping forward, tests in sight!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6dd2d8 and 94982fd.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run tests under miri
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Ensure compilation on various targets
🔇 Additional comments (1)
.github/workflows/ci.yaml (1)

281-282:

❓ Verification inconclusive

Remove macOS skips and run all platform-dependent tests

The updated step now excludes only platform‐independent tests without any macOS‐specific skips. Confirm that removing $MACOS_SKIPS doesn’t reintroduce hanging tests on both ARM and Intel macOS runners and that all previously skipped tests (test_configparser, test_socketserver) pass reliably.

Please run:

and observe the CI results on both macos-latest (ARM) and Intel images.

🏁 Script executed:

#!/usr/bin/env bash
# Search for any remaining MACOS_SKIPS references
rg -n 'MACOS_SKIPS' .

Length of output: 21

No remaining MACOS_SKIPS references found

I ran rg -n 'MACOS_SKIPS' . and confirmed there are no matches in the codebase. All macOS skips have been removed.

• Please verify that the CI on both ARM (macos-latest) and Intel macOS runners completes without hanging and that previously skipped tests (e.g. test_configparser, test_socketserver) pass reliably.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

youknowone
youknowone approved these changes Jun 15, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit c968fe0 into RustPython:main Jun 15, 2025
11 of 12 checks passed
@arihant2math arihant2math deleted the no-macos-skips branch June 28, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arihant2math @youknowone