Iterable for PyGenericAlias #5876
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (5)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe changes remove the Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Lib/test/test_typing.py (1)
2667-2670: Enhance the TODO comment with specific reason.The change correctly follows the test modification guidelines by adding
@unittest.expectedFailurewith the required# TODO: RUSTPYTHONcomment. However, consider adding a specific reason to the TODO comment to better document why this test is expected to fail in RustPython.- # TODO: RUSTPYTHON + # TODO: RUSTPYTHON: collections.abc.Callable error handling differs from typing.Callable
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
vm/src/builtins/genericalias.rsis excluded by none and included by nonevm/src/builtins/union.rsis excluded by none and included by nonevm/src/frame.rsis excluded by none and included by nonevm/src/stdlib/mod.rsis excluded by none and included by nonevm/src/stdlib/typing.rsis excluded by none and included by nonevm/src/vm/context.rsis excluded by none and included by none
📒 Files selected for processing (1)
Lib/test/test_typing.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
`**/*.py`: Follow PEP 8 style for custom Python code Use ruff for linting Python code
**/*.py: Follow PEP 8 style for custom Python code
Use ruff for linting Python code
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
Lib/test/test_typing.py
`Lib/**/*.py`: Minimize modifications to CPython standard library files in the `Lib/` directory
Lib/**/*.py: Minimize modifications to CPython standard library files in theLib/directory
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
Lib/test/test_typing.py
`Lib/test/**/*.py`: NEVER comment out or delete any test code lines except for r...
Lib/test/**/*.py: NEVER comment out or delete any test code lines except for removing@unittest.expectedFailuredecorators and upper TODO comments in test files
NEVER modify test assertions, test logic, or test data in test files
When a test cannot pass due to missing language features, keep it as expectedFailure and document the reason
The only acceptable modifications to test files are: 1. Removing@unittest.expectedFailuredecorators and the upper TODO comments when tests actually pass 2. Adding@unittest.expectedFailuredecorators when tests cannot be fixed
Add a# TODO: RUSTPYTHONcomment when modifications are made to tests inLib/test
Useunittest.skip("TODO: RustPython <reason>")orunittest.expectedFailurewith# TODO: RUSTPYTHON <reason>comment in test files when skipping or marking expected failures
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
Lib/test/test_typing.py
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : The only acceptable modifications to test files are: 1. Removing `@unittest.expectedFailure` decorators and the upper TODO comments when tests actually pass 2. Adding `@unittest.expectedFailure` decorators when tests cannot be fixed
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : NEVER comment out or delete any test code lines except for removing `@unittest.expectedFailure` decorators and upper TODO comments in test files
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : When a test cannot pass due to missing language features, keep it as expectedFailure and document the reason
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Use `unittest.skip("TODO: RustPython <reason>")` or `unittest.expectedFailure` with `# TODO: RUSTPYTHON <reason>` comment in test files when skipping or marking expected failures
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Lib/test/test_typing.py (6)
undefined
<retrieved_learning>
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : The only acceptable modifications to test files are: 1. Removing @unittest.expectedFailure decorators and the upper TODO comments when tests actually pass 2. Adding @unittest.expectedFailure decorators when tests cannot be fixed
</retrieved_learning>
<retrieved_learning>
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a # TODO: RUSTPYTHON comment when modifications are made to tests in Lib/test
</retrieved_learning>
<retrieved_learning>
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Use unittest.skip("TODO: RustPython <reason>") or unittest.expectedFailure with # TODO: RUSTPYTHON <reason> comment in test files when skipping or marking expected failures
</retrieved_learning>
<retrieved_learning>
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : NEVER comment out or delete any test code lines except for removing @unittest.expectedFailure decorators and upper TODO comments in test files
</retrieved_learning>
<retrieved_learning>
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : When a test cannot pass due to missing language features, keep it as expectedFailure and document the reason
</retrieved_learning>
<retrieved_learning>
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : NEVER modify test assertions, test logic, or test data in test files
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Run tests under miri
- GitHub Check: Run rust tests (macos-latest)
- GitHub Check: Run snippets and cpython tests (macos-latest)
- GitHub Check: Run snippets and cpython tests (windows-latest)
- GitHub Check: Check Rust code with rustfmt and clippy
- GitHub Check: Run rust tests (windows-latest)
- GitHub Check: Ensure compilation on various targets
- GitHub Check: Check the WASM package and demo
youknowone
force-pushed
the
genericalias-iterable
branch
from
12440db to
021b8eb
Compare
Summary by CodeRabbit