refactor: serialize clipboard to json instead of html #1790
+38
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to serialize everything into
blocknote/html
, we can instead serialize intoblocknote/json
whatever slice of data we want to be on the clipboard or drag & drop.This should resolve a number of issues related to drag & drop, and simplifies things significantly.
HTML cannot encode the same sort of information that json can, for example, that a slice has different depths is not representable by html & has to be inferred, whereas just representing it as a slice, just works.
Does not resolve:
BlockNote/packages/core/src/extensions/SideMenu/SideMenuPlugin.ts
Lines 301 to 335 in 0eb3bce
What is left?