fix: Duplicate formatConversionTest files
#1798
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
requested changes
Jul 1, 2025
| addIdsToBlock(block); | ||
| } | ||
| } | ||
| export * from "@shared/formatConversionTestUtil.js"; |
There was a problem hiding this comment.
let's for now remove this file altogether and directly reference @shared/formatConversionTestUtil. This makes the codebase consistent and less "in limbo" state.
If we want to prioritize moving all unit tests, we should discuss this with 3 of us. Atm I'm not immediately convinced; afaik we decided on moving the formatting tests to a shared directory, because they shared similar logic - but we didn't settle on a rule to "have all unit tests" in /tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the duplicate
formatConversionTestfiles, and only preserves the one in the@shareddirectory. This is still not ideal as really, all the unit tests should be within/tests/, but that is a pretty big refactor that imo is for another time Thexl-tests-refactorbranch has an early WIP for that, when I was checking how much work it is.