[FragmentStrictMode] Detect Fragment reuse #142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbw0033
requested changes
Mar 16, 2021
| @@ -283,6 +283,10 @@ public void run() { | |||
| // track it separately. | |||
| boolean mIsCreated; | |||
|
|
|||
| // True if the fragment was already added to a FragmentManager, but has since been removed | |||
| // again. | |||
| boolean mRemovedFromFragmentManager; | |||
There was a problem hiding this comment.
This name is long, I think mRemoved would be enough.
|
Build should be passing again now - if you rebase this checks should pass. |
simonschiller
force-pushed
the
feature/fragment-reuse
branch
from
319d1ce to
d769700
Compare
|
Rebased and the checks here seem fine, but I got an email notification telling me that they didn't pass. Is this branch green on your internal CI? |
|
I think the lint check has some issues with api files right now on push events - feel free to ignore since checks here are passing. |
simonschiller
force-pushed
the
feature/fragment-reuse
branch
from
d769700 to
f182f85
Compare
jbw0033
approved these changes
Mar 22, 2021
simonschiller
force-pushed
the
feature/fragment-reuse
branch
from
f182f85 to
d9bcea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
FragmentinstancesTesting
Test: See
FragmentStrictModeTest#detectFragmentReuseandFragmentStrictModeTest#detectFragmentReuseInFlightTransactionIssues Fixed
Fixes: 153738653