fix(core): infer tag name for test root component #62283
Conversation
Currently when a component is inserted, the tag name of its host is inferred from the selector, however in tests we always render it out as a `div`. These changes switch to inferring the tag name so that things like `querySelector` work consistently.
crisbeto
added
action: review
| const testComponentRenderer = this.inject(TestComponentRenderer); | ||
| const componentDef: ComponentDef<T> = (type as any).ɵcmp; | ||
| const rootElId = `root${_nextRootElementId++}`; | ||
| const defaultTag = componentDef.selectors[0][0] as string; |
There was a problem hiding this comment.
Does this also work for non-trivial selectors, e.g. button[matButton]?
There was a problem hiding this comment.
Yes, this is the selector after it has been parsed by the compiler into a CssSelectorList
There was a problem hiding this comment.
@crisbeto it looks like it is roughly the same logic as in
angular/packages/core/src/render3/component_ref.ts
Lines 190 to 192 in b848590
The main difference being that component ref takes namespace into account (?). Maybe it would make sense to factor this out and re-use?
There was a problem hiding this comment.
Hmm good callout, although I guess there aren't many usages of SVG or MathML for component roots since we haven't heard about this before.
There was a problem hiding this comment.
Yeh, I was just looking at it from the "don't duplicate code / concepts" side of things
| // Note: injecting the renderer before accessing the definition appears to be load-bearing. | ||
| const testComponentRenderer = this.inject(TestComponentRenderer); | ||
| const componentDef: ComponentDef<T> = (type as any).ɵcmp; | ||
| const rootElId = `root${_nextRootElementId++}`; |
There was a problem hiding this comment.
Optional nit: It'd be nice to have a comment for the next two lines explaining what this is doing.
Currently when a component is inserted, the tag name of its host is inferred from the selector, however in tests we always render it out as a
div.These changes switch to inferring the tag name so that things like
querySelectorwork consistently.