Skip to content

refactor(core): use quad linked signal nodes for performance #62284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(core): use quad linked signal nodes for performance #62284

wants to merge 2 commits into from

Conversation

milomg
Copy link
Contributor

@milomg milomg commented Jun 26, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Switch to using https://preactjs.com/blog/signal-boosting/ for a performance boost in signal initialization

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 26, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 26, 2025
@milomg milomg force-pushed the linked branch 2 times, most recently from 641b2fd to 50fe202 Compare June 26, 2025 08:19
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jun 26, 2025
@milomg milomg force-pushed the linked branch 5 times, most recently from 81e4b59 to cd3604f Compare June 28, 2025 06:03
@milomg
refactor(core): use quad linked lists for signals
2a99ad2 
inspired by the design of Preact's signals, use linked lists instead of arrays for faster signal creation
@milomg
fix(core): update symbols for new signals api
d19ace3 
approve the new symbols that appear from bundling the signals changes
@milomg milomg marked this pull request as ready for review June 28, 2025 07:03
@pullapprove pullapprove bot requested review from atscott, iteriani and kirjs June 28, 2025 07:03
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 28, 2025
@milomg
Copy link
Contributor Author

milomg commented Jun 30, 2025 •
edited
Loading

Patch cl/777701693, currently running TGP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atscott atscott Awaiting requested review from atscott

@iteriani iteriani Awaiting requested review from iteriani

@kirjs kirjs Awaiting requested review from kirjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@milomg @thePunderWoman