Skip to content

fix(devtools): restore the router tree visualization legend #62378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hawkgs
Copy link
Member

@hawkgs hawkgs commented Jun 30, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

#62264 drops the legend since it was part of the SVG visualization.

What is the new behavior?

Fixes the regression by adding the legend in the HTML template instead.

@hawkgs hawkgs requested a review from dgp1130 June 30, 2025 12:08
@ngbot ngbot bot added this to the Backlog milestone Jun 30, 2025
@hawkgs hawkgs added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 30, 2025
@hawkgs hawkgs force-pushed the devtools/restore-router-tree-legend branch from b5274ca to 8d1c2f8 Compare June 30, 2025 14:38
@hawkgs hawkgs added target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 30, 2025
@hawkgs
Copy link
Member Author

hawkgs commented Jul 1, 2025

@dgp1130, I'll open a follow up PR that makes the tree visualizations accessible. The legend is aria-hidden.

@hawkgs hawkgs added the action: merge The PR is ready for merge by the caretaker label Jul 1, 2025
@thePunderWoman thePunderWoman added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 1, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit b25fb8a.

The changes were merged into the following branches: main

@hawkgs hawkgs deleted the devtools/restore-router-tree-legend branch July 1, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: devtools target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants