Skip to content

Refactor RestHandler state machine into a coroutine #21787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 59 commits into
base: devel
Choose a base branch
from

Conversation

goedderz
Copy link
Member

@goedderz goedderz commented May 27, 2025

Scope & Purpose

Refactor the RestHandler's state machine into a coroutine. This is foundational work to allow rewriting more code into (asynchronous) coroutines.

  • 🔨 Refactoring/simplification

Checklist

  • Covered by existing tests

goedderz and others added 30 commits February 13, 2025 14:09
- Temporarily disabled LogContext (ScopedValue in rest handler state
  machine)
- Made more stuff async
- Fixed an issue by moving a coro from Future to async, because futures
  don't pass ExecContext as coros (just as an awaitable)
- Fixed an issue by moving WAITING<->coro adapter further up the stack
…e+waitForFuture

The following handlers are changed:

- RestAgencyHandler
- RestAdminLogHandler
- RestDocumentHandler
- RestGraphHandler
- RestImportHandler
- RestLogHandler
- RestLogInternalHandler
- RestMetricsHandler
- RestReplicationHandler
- RestTransactionHandler
- RestUsageMetricsHandler
…ub.com:arangodb/arangodb into feature/refactor-resthandler-state-machine-into-coro
@goedderz goedderz added this to the devel milestone May 27, 2025
@goedderz goedderz self-assigned this May 27, 2025
@cla-bot cla-bot bot added the cla-signed label May 27, 2025
@goedderz goedderz changed the base branch from devel to test/prevent-races-in-chaos-streaming-trx-tests June 9, 2025 11:15
goedderz added 2 commits June 9, 2025 20:02
…hub.com:arangodb/arangodb into feature/refactor-resthandler-state-machine-into-coro
Base automatically changed from test/prevent-races-in-chaos-streaming-trx-tests to devel June 24, 2025 14:16
goedderz added 3 commits June 25, 2025 17:19
- LogContext handling in RestHandler
- Moved waitingFunToCoro to SuspensionCounter.h
@goedderz goedderz marked this pull request as ready for review June 27, 2025 11:27
@goedderz goedderz requested a review from a team June 27, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant