-
Notifications
You must be signed in to change notification settings - Fork 853
Bug fix/bts 2152 fix overfetch input on parallel traversals #21808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mchacki
wants to merge
12
commits into
devel
Choose a base branch
from
bug-fix/bts-2152-fix-overfetch-input-on-parallel-traversals
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bug fix/bts 2152 fix overfetch input on parallel traversals #21808
mchacki
wants to merge
12
commits into
devel
from
bug-fix/bts-2152-fix-overfetch-input-on-parallel-traversals
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbajic
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me but I am not really familiar with this part of codebase
@@ -1,6 +1,21 @@ | |||
devel | |||
----- | |||
|
|||
* Fix BTS-2152 Overfetch input on prallel Traversals. For queries like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* Fix BTS-2152 Overfetch input on prallel Traversals. For queries like this: | |
* Fix BTS-2152 Overfetch input on parallel Traversals. For queries like this: |
Co-authored-by: Jure Bajic <jure.bajic94@gmail.com>
Co-authored-by: Jure Bajic <jure.bajic94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Fix BTS-2152 Overfetch input on prallel Traversals. For queries like this:
FOR x IN largeCollection
FOR v IN 1 OUTBOUND x edges {parallelism: 4}
LIMIT 10
RETURN v
Before this bugfix we would always enumerate largeCollection in full,
even though a small portion of the collection would have sufficed.
This is now handled better. We now enumerate only the necessary amount
of batches required to fulfill the limit.
This also improves cluster queries (replace the traversal with another FOR loop)
which had the same behaviour and are now enumerating less unused
intermediate results.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)