Skip to content

Bug fix/bts 2152 fix overfetch input on parallel traversals #21808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: devel
Choose a base branch
from

Conversation

mchacki
Copy link
Member

@mchacki mchacki commented Jun 18, 2025

Scope & Purpose

Fix BTS-2152 Overfetch input on prallel Traversals. For queries like this:

FOR x IN largeCollection
FOR v IN 1 OUTBOUND x edges {parallelism: 4}
LIMIT 10
RETURN v

Before this bugfix we would always enumerate largeCollection in full,
even though a small portion of the collection would have sufficed.
This is now handled better. We now enumerate only the necessary amount
of batches required to fulfill the limit.
This also improves cluster queries (replace the traversal with another FOR loop)
which had the same behaviour and are now enumerating less unused
intermediate results.

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2025
@mchacki mchacki self-assigned this Jun 23, 2025
Copy link
Contributor

@jbajic jbajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I am not really familiar with this part of codebase

@@ -1,6 +1,21 @@
devel
-----

* Fix BTS-2152 Overfetch input on prallel Traversals. For queries like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix BTS-2152 Overfetch input on prallel Traversals. For queries like this:
* Fix BTS-2152 Overfetch input on parallel Traversals. For queries like this:

mchacki and others added 2 commits June 30, 2025 15:30
Co-authored-by: Jure Bajic <jure.bajic94@gmail.com>
Co-authored-by: Jure Bajic <jure.bajic94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants