Couple of fixes #174
Merged
Couple of fixes #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gpyh Hello and thanks for your contribution :) Some improvements where actually done in |
|
Rebased and force-pushed. The code improvement has already been made. |
|
lib/components/nav-item.vue:10:23 Have you some time fixing small ESLint problems too ? |
|
Sorry, I didn't lint it. Will do shortly. |
It used to embed the b-link component without importing it
|
Done. |
|
@gpyh Thanks body :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make some fixes for a project I'm working on. I'm sharing them back upstream.
In details :
b-link. This fixes that issue.Slight code improvement for bFormInput: it usesisinstead ofv-ifto switch between input and textarea. If found this cleaner.