Skip to content

Clarify potential issue with dynamic python library #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

behrica
Copy link
Contributor

@behrica behrica commented Jan 12, 2023

and that it cannot be found in all cases, and what to do in such situation.

and that it cannot be found in all cases, and what to do in such situation.
@cnuernber
Copy link
Collaborator

This is a good direction - we need to fix the verbiage - One suggestion -

In some situations we are unable to a dynamic library libpythonx.y.so or
libpythonx.z.dylib. if python is statically linked it may not be present at all.
This is OS / installation dependent and cannot be reliably detected in all cases.
In such situation we fail with error: Failed to find a valid python library!.
You may then be required to install additional OS level packages and / or set the precise library location manually during py/initialize!.

Honestly for quite a few of our users a document describing what a shared library is, how we attempt to detect the location of the python shared library, and the above quote would probably also be a good idea but this PR certainly makes things a bit better than they were before.

@behrica behrica changed the title Clarify that about dynamic python library Clarify potential issue with dynamic python library Feb 27, 2023
using GTP-3
@behrica
Copy link
Contributor Author

behrica commented Feb 27, 2023

@cnuernber
I till think the small clarification is better then no detail.

@cnuernber cnuernber merged commit 953e42f into clj-python:master Feb 28, 2023
@cnuernber
Copy link
Collaborator

Agreed - the clarification is important and useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants