fix: appium touch perform #5035
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
|
@nlespiaucq would you mind advising this https://github.com/codeceptjs/CodeceptJS/actions/runs/15993586675/job/45111776356#step:6:96 |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Appium helper to use W3C actions for touch interactions, updates the corresponding documentation and tests, and standardizes CI workflow YAML quoting and triggers.
- Refactored
touchPerformhelper method to callbrowser.performActionsand updated JSDoc/examples. - Tagged the touch-perform integration test with
@quick. - Converted Appium docs to single-quote syntax, removed semicolons, and realigned example blocks.
- Standardized quoting in CI workflows and adjusted the Appium Android workflow trigger.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/helper/Appium_test.js | Added @quick tag to the touchPerform test title |
| lib/helper/Appium.js | Switched touchPerform from touchPerform to performActions |
| docs/helpers/Appium.md | Updated touchPerform docs, code examples switched to single quotes |
| docs/plugins.md | Removed stray list marker |
| .github/workflows/check.yml | Standardized YAML quoting |
| .github/workflows/appium_Android.yml | Broadened branch trigger |
Comments suppressed due to low confidence (4)
.github/workflows/appium_Android.yml:7
- Using the wildcard
'**'in branch triggers will run this workflow on every branch. Consider narrowing it to intended branches to reduce unnecessary CI runs.
- '**'
test/helper/Appium_test.js:330
- Verify that the test suite is configured to recognize the
@quicktag; otherwise this annotation may be ignored by the runner.
it('should react on touchPerform action @quick', async () => {
docs/helpers/Appium.md:760
- [nitpick] The markdown list structure in this section has inconsistent indentation and markers after the bulk update. Align nested bullets and code fences to improve readability.
Performs a specific touch action using W3C actions.
lib/helper/Appium.js:1375
- After calling
performActions, consider invokingreleaseActions()orclearActions()on the browser to reset the input state and avoid residual pointer sessions.
return this.browser.performActions(actions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)