WIP: Working on testing improvement

defelmnq · defelmnq · commit 51b1e519a405 · 2024-10-24T13:04:10.000Z
diff --git a/coderd/users_test.go b/coderd/users_test.go
@@ -1084,22 +1084,24 @@ func TestUpdateUserPassword(t *testing.T) {
 		require.Equal(t, database.AuditActionWrite, auditor.AuditLogs()[numLogs-1].Action)
 	})
 
-	// FIXME:  Re-enable the tests once real logic changed
+	// FIXME: Re-enable the tests once real logic changed
 	// Currently there's no check in code to validate that users have to put the old password
-	// t.Run("MemberCantUpdateOwnPasswordWithoutOldPassword", func(t *testing.T) {
-	// 	t.Parallel()
-	// 	client := coderdtest.New(t, nil)
-	// 	owner := coderdtest.CreateFirstUser(t, client)
-	// 	member, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
-
-	// 	ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
-	// 	defer cancel()
-
-	// 	err := member.UpdateUserPassword(ctx, "me", codersdk.UpdateUserPasswordRequest{
-	// 		Password: "newpassword",
-	// 	})
-	// 	require.Error(t, err, "member should not be able to update own password without providing old password")
-	// })
+	t.Run("MemberCantUpdateOwnPasswordWithoutOldPassword", func(t *testing.T) {
+		t.Skip()
+
+		t.Parallel()
+		client := coderdtest.New(t, nil)
+		owner := coderdtest.CreateFirstUser(t, client)
+		member, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
+
+		ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
+		defer cancel()
+
+		err := member.UpdateUserPassword(ctx, "me", codersdk.UpdateUserPasswordRequest{
+			Password: "newpassword",
+		})
+		require.Error(t, err, "member should not be able to update own password without providing old password")
+	})
 
 	t.Run("AuditorCantTellIfPasswordIncorrect", func(t *testing.T) {
 		t.Parallel()
