Skip to content

Commit da54c8a

Browse files
authored
fix: fix data race in TestLabelsAggregation tests (#12578)
1 parent 7a7105a commit da54c8a

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

coderd/prometheusmetrics/aggregator_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,14 +204,17 @@ func verifyCollectedMetrics(t *testing.T, expected []*agentproto.Stats_Metric, a
204204
require.Failf(t, "unsupported type: %s", string(e.Type))
205205
}
206206

207+
expectedLabels := make([]*agentproto.Stats_Metric_Label, len(e.Labels))
208+
copy(expectedLabels, e.Labels)
209+
207210
dtoLabels := asMetricAgentLabels(d.GetLabel())
208211
// dto labels are sorted in alphabetical order.
209212
sortFn := func(i, j int) bool {
210-
return e.Labels[i].Name < e.Labels[j].Name
213+
return expectedLabels[i].Name < expectedLabels[j].Name
211214
}
212-
sort.Slice(e.Labels, sortFn)
215+
sort.Slice(expectedLabels, sortFn)
213216
sort.Slice(dtoLabels, sortFn)
214-
require.Equal(t, e.Labels, dtoLabels, d.String())
217+
require.Equal(t, expectedLabels, dtoLabels, d.String())
215218
}
216219
return true
217220
}

0 commit comments

Comments
 (0)