fix: fix data race in TestLabelsAggregation tests #12578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping
changed the title
johnstcn
approved these changes
Mar 13, 2024
Comment on lines
208
to
214
| var expectedLabels []*agentproto.Stats_Metric_Label | ||
| for _, l := range e.Labels { | ||
| expectedLabels = append(expectedLabels, &agentproto.Stats_Metric_Label{ | ||
| Name: l.Name, | ||
| Value: l.Value, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Why not copy(expectedLabels, e.Labels)?
There was a problem hiding this comment.
Good call! I tried it before but it wasn't working, but now I realise I needed to size the dst slice first 🤦
Fixed in 9113c015e
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen here: https://github.com/coder/coder/actions/runs/8262787141/job/22602878845