feat: add --version flag to coder templates pull, default to active version
#10153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
deansheather
approved these changes
Oct 9, 2023
Comment on lines
+52
to
73
| var latestVersion codersdk.TemplateVersion | ||
| { | ||
| // Determine the latest template version and compare with the | ||
| // active version. If they aren't the same, warn the user. | ||
| versions, err := client.TemplateVersionsByTemplate(ctx, codersdk.TemplateVersionsByTemplateRequest{ | ||
| TemplateID: template.ID, | ||
| }) | ||
| if err != nil { | ||
| return xerrors.Errorf("template versions by template: %w", err) | ||
| } | ||
|
|
||
| if len(versions) == 0 { | ||
| return xerrors.Errorf("no template versions for template %q", templateName) | ||
| } | ||
|
|
||
| // Sort the slice from newest to oldest template. | ||
| sort.SliceStable(versions, func(i, j int) bool { | ||
| return versions[i].CreatedAt.After(versions[j].CreatedAt) | ||
| }) | ||
|
|
||
| if len(versions) == 0 { | ||
| return xerrors.Errorf("no template versions for template %q", templateName) | ||
| latestVersion = versions[0] | ||
| } |
There was a problem hiding this comment.
You should move this into the switch when you pick latest
There was a problem hiding this comment.
I need to know the latest version for the warning when the version isn't specified.
coadler
deleted the
colin/featadd--versionflagtocodertemplatespulldefaulttoactiveversion
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9837