-
Notifications
You must be signed in to change notification settings - Fork 936
feat: implement basic archive ui to make archiving failed versions easy #10182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cc560ca
chore: Add archive column to template versions
Emyrk ba1310a
Linting
Emyrk b804fcf
Make gen
Emyrk b9160ae
Add comment on unit test
Emyrk 49b509b
Linting
Emyrk 7c09da2
feat: add archiving template versions to hide from ui
Emyrk 2a2de29
Update golden files
Emyrk 17132e6
Merge remote-tracking branch 'origin/main' into stevenmasley/archive_…
Emyrk 105f8c8
Merge remote-tracking branch 'origin/main' into stevenmasley/archive_…
Emyrk 965539f
feat: implement basic archive ui to make archiving failed versions easy.
Emyrk 2a1f3ee
Add verbage
Emyrk 69d25de
make fmt
Emyrk e3d9ed6
add swager annotation
Emyrk 5505753
Switch to ternany
Emyrk a4346d0
flipped bool logic
Emyrk b74246c
revert to main
Emyrk a52fcbf
Merge remote-tracking branch 'origin/main' into stevenmasley/archive_ui
Emyrk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the queries and mutations we are putting into the api/queries modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copy pasted what was above, and changed it to archive vs promote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we refactor this in another PR?
I think I need to learn this new style of pushing the mutation to an external package. I thought it would be a copy paste, but it is not.
The current code is async and works on
useState
and callbacks, but it seems the new way is toawait
?