Skip to content

feat: add workspace_id, owner_name to agent manifest #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 3, 2023
Merged

feat: add workspace_id, owner_name to agent manifest #10199

merged 8 commits into from
Dec 3, 2023

Conversation

szab100
Copy link
Contributor

@szab100 szab100 commented Oct 11, 2023

Add WorkspaceID to the response of GET:/workspaceagents/me/manifest to allow finding workspaces by agent.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@szab100
Copy link
Contributor Author

szab100 commented Oct 11, 2023

I have read the CLA Document and I hereby sign the CLA

@szab100
Copy link
Contributor Author

szab100 commented Oct 11, 2023

recheck

cdrcommunity added a commit to coder/cla that referenced this pull request Oct 11, 2023
@cdrcommunity
@szab100 has signed the CLA in coder/coder#10199
6040df9
kylecarbs
kylecarbs approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well run gen on this for ya. Could you add a comment why it's needed for your case? Just so we don't randomly remove it in the future.

@szab100
Copy link
Contributor Author

szab100 commented Oct 11, 2023 •
edited
Loading

Well run gen on this for ya. Could you add a comment why it's needed for your case? Just so we don't randomly remove it in the future.

Sorry, it looks like the comment became part of the swagger spec.. I couldn't get it to ignore the comment there, moved it to the test file instead..

Also, can we please add the workspace owner too?

OwnerName:      owner.Username

Since it is already pulled / used here (for the vscode proxy url) and in some of our scenarios, we don't need to pull the workspace as the owner (username) is all we need to verify.

@szab100 szab100 changed the title feat: add workspace_id to agent manifest response feat: add workspace_id, owner_name to agent manifest Oct 11, 2023
@szab100 szab100 requested a review from kylecarbs October 13, 2023 00:06
@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 20, 2023
@github-actions github-actions bot closed this Oct 23, 2023
@szab100
Copy link
Contributor Author

szab100 commented Oct 23, 2023

Hi @kylecarbs, I see this has been closed (stale).. is this still good to go?

@kylecarbs kylecarbs reopened this Nov 1, 2023
kylecarbs
kylecarbs reviewed Nov 1, 2023
View reviewed changes
szab100 and others added 2 commits November 1, 2023 10:53
@szab100 @kylecarbs
Update codersdk/agentsdk/agentsdk.go
27e0129 
Co-authored-by: Kyle Carberry <kyle@carberry.com>
@szab100
Update workspaceagents_test.go
5980d2e
@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 2, 2023
@matifali
Copy link
Member

matifali commented Nov 9, 2023

@kylecarbs, is it ok to merge this?

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 17, 2023
@github-actions github-actions bot closed this Nov 20, 2023
@matifali matifali reopened this Nov 20, 2023
@matifali matifali removed the stale This issue is like stale bread. label Nov 20, 2023
@szab100
Copy link
Contributor Author

szab100 commented Nov 27, 2023

@matifali @kylecarbs Thanks for reopening. Can we get this merged? Since we would like to start consuming this asap. 🙏

@matifali matifali merged commit baf3bf6 into coder:main Dec 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@szab100 szab100

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szab100 @matifali @kylecarbs