Skip to content

chore(site): remove create workspace xservice #10217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 11, 2023
Merged

chore(site): remove create workspace xservice #10217

merged 22 commits into from
Oct 11, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to #9940

@BrunoQuaresma BrunoQuaresma requested a review from a team October 11, 2023 14:47
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 11, 2023
@BrunoQuaresma BrunoQuaresma requested review from aslilac and removed request for a team October 11, 2023 14:47
Parkreiner
Parkreiner approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too much to say – I think this looks good overall. Just had one suggestion for cleaning up one of the new useEffect calls

site/src/pages/CreateWorkspacePage/permissions.ts
@@ -0,0 +1,16 @@
export const createWorkspaceChecks = (organizationId: string) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that these types are coming from XState. Do we have any files that have some of these types defined for when we eventually remove the library? One of my worries is that once we remove XState, our codebase will still be partly influenced by how it sets things up, but we won't have the type definitions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nops, there is no types coming from XState here 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just assumed that they were, because I've seen a few objects structured with these object and action properties around the codebase, and I know "action" is a state machine term

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is not, it is related to our internal RBAC system 😁

Base automatically changed from bq/refactor-auth-xservice to main October 11, 2023 20:13
@Parkreiner Parkreiner enabled auto-merge (squash) October 11, 2023 20:38
@Parkreiner Parkreiner merged commit 301c045 into main Oct 11, 2023
@Parkreiner Parkreiner deleted the bq/refactor-create-workspace branch October 11, 2023 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

@aslilac aslilac Awaiting requested review from aslilac aslilac was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @Parkreiner