Skip to content

chore(coderd/coderdtest): use testing.TB for use in benchmarks #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

mafredri
Copy link
Member

No description provided.

@mafredri mafredri self-assigned this Oct 12, 2023
@mafredri mafredri requested review from johnstcn and mtojek October 12, 2023 10:04
@johnstcn
Copy link
Member

Should we make a linter rule for this perhaps?

@mafredri
Copy link
Member Author

Should we make a linter rule for this perhaps?

I don't think it's worth it for just test code, it's very easy to change on an as-needed basis.

@mafredri mafredri merged commit 7df40b8 into main Oct 12, 2023
@mafredri mafredri deleted the mafredri/coderdtest-use-testing-tb branch October 12, 2023 12:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants