fix(scaletest): fix flake in Test_Runner/Cleanup #10252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10240
From the linked issue:
require.Eventually
that asserts that the build was canceledBased on the above, it looks like a race between
runner.Cleanup
doing its thing and therequire.Eventually
asserting that cleanup happened. I don't see a simple way to synchronize between these two actions, so to reduce the likelihood of this happening in future and hoepfully aid future troubleshooting:I wasn't able to recrate the original failure after running the test 100 times with
DB=ci
and-race
, so while not 100% confident this completely fixes the flake, I'm hopeful at least.