chore: use emotion for styling (pt. 5) #10261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
requested review from
a team,
BrunoQuaresma,
Kira-Pilot and
Parkreiner
and removed request for
a team
BrunoQuaresma
approved these changes
Oct 16, 2023
Closed
Parkreiner
reviewed
Oct 16, 2023
| }, | ||
| }, | ||
| const styles = { | ||
| root: (theme) => css` |
There was a problem hiding this comment.
Just a question for my own understanding: is there a difference between an interpolation function returning an object, vs a tagged css template literal? Is the main use case to enable the & selectors, or would something like this still be possible via object syntax?
const styles = {
"&:hover": (theme) => ({
background-color: ${theme.palette.background.paper};
})
};| Stacktrace | ||
| <CopyButton | ||
| buttonClassName={styles.copyButton} | ||
| buttonClassName={css` |
There was a problem hiding this comment.
I think there's some nuance that I'm missing. Is there anything stopping this style from being defined outside the component, and being defined via the interpolation function syntax that some of the other styles are using?
I don't expect it to matter much performance-wise – just curious
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9924
Following #10149
From starting with 157 usages of makeStyles across 154 files, this changes brings us down to 69 usages across as many files.