chore(site): remove template version machine #10315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
requested review from
code-asher
and removed request for
a team
code-asher
approved these changes
Oct 17, 2023
| version: TemplateVersion, | ||
| ) => { | ||
| const previousVersion = await API.getPreviousTemplateVersionByName( | ||
| version.organization_id!, |
There was a problem hiding this comment.
Is this one of those cases where the types are wrong or is it possible for the ID to be undefined?
There was a problem hiding this comment.
When this happens, it is impossible for the organization id to be undefined. More context: A version can be created without being attached to a template or even an organization.
Co-authored-by: Asher <ash@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #9941