Skip to content

chore(site): remove workspace schedule machine #10583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2023
Merged

chore(site): remove workspace schedule machine #10583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41417db
Extract permissions to the page
BrunoQuaresma Nov 8, 2023
d09c4f8
Move template data and a few errors to the page
BrunoQuaresma Nov 8, 2023
4d9f8b7
Move submit logic
BrunoQuaresma Nov 8, 2023
5d3236e
Remove workspace schedule service
BrunoQuaresma Nov 8, 2023
a3a09ae
Fix confirm apply
BrunoQuaresma Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
185 changes: 115 additions & 70 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceSchedulePage/WorkspaceSchedulePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { useMachine } from "@xstate/react";
import { Alert } from "components/Alert/Alert";
import { ConfirmDialog } from "components/Dialogs/ConfirmDialog/ConfirmDialog";
import { Loader } from "components/Loader/Loader";
Expand All @@ -10,25 +9,38 @@ import {
} from "pages/WorkspaceSettingsPage/WorkspaceSchedulePage/schedule";
import { ttlMsToAutostop } from "pages/WorkspaceSettingsPage/WorkspaceSchedulePage/ttl";
import { useWorkspaceSettings } from "pages/WorkspaceSettingsPage/WorkspaceSettingsLayout";
import { FC } from "react";
import { FC, useState } from "react";
import { Helmet } from "react-helmet-async";
import { Navigate, useNavigate, useParams } from "react-router-dom";
import { useNavigate, useParams } from "react-router-dom";
import { pageTitle } from "utils/page";
import * as TypesGen from "api/typesGenerated";
import { workspaceByOwnerAndNameKey } from "api/queries/workspaces";
import { WorkspaceScheduleForm } from "./WorkspaceScheduleForm";
import { workspaceSchedule } from "xServices/workspaceSchedule/workspaceScheduleXService";
import {
formValuesToAutostartRequest,
formValuesToTTLRequest,
} from "./formToRequest";
import { ErrorAlert } from "components/Alert/ErrorAlert";
import { useQueryClient } from "react-query";
import { useMutation, useQuery, useQueryClient } from "react-query";
import { checkAuthorization } from "api/queries/authCheck";
import { templateByName } from "api/queries/templates";
import {
putWorkspaceAutostart,
putWorkspaceAutostop,
startWorkspace,
} from "api/api";

const getAutostart = (workspace: TypesGen.Workspace) =>
scheduleToAutostart(workspace.autostart_schedule);
const getAutostop = (workspace: TypesGen.Workspace) =>
ttlMsToAutostop(workspace.ttl_ms);
const permissionsToCheck = (workspace: TypesGen.Workspace) =>
({
updateWorkspace: {
object: {
resource_type: "workspace",
resource_id: workspace.id,
owner_id: workspace.owner_id,
},
action: "update",
},
}) as const;

export const WorkspaceSchedulePage: FC = () => {
const params = useParams() as { username: string; workspace: string };
Expand All @@ -37,24 +49,28 @@ export const WorkspaceSchedulePage: FC = () => {
const workspaceName = params.workspace;
const queryClient = useQueryClient();
const workspace = useWorkspaceSettings();
const [scheduleState, scheduleSend] = useMachine(workspaceSchedule, {
context: { workspace },
const { data: permissions, error: checkPermissionsError } = useQuery(
checkAuthorization({ checks: permissionsToCheck(workspace) }),
);
const { data: template, error: getTemplateError } = useQuery(
templateByName(workspace.organization_id, workspace.template_name),
);
const submitScheduleMutation = useMutation({
mutationFn: submitSchedule,
onSuccess: async () => {
await queryClient.invalidateQueries(
workspaceByOwnerAndNameKey(params.username, params.workspace),
);
},
});
const {
checkPermissionsError,
submitScheduleError,
getTemplateError,
permissions,
template,
} = scheduleState.context;

if (!username || !workspaceName) {
return <Navigate to="/workspaces" />;
}
const error = checkPermissionsError || getTemplateError;
const isLoading = !template || !permissions;

if (scheduleState.matches("done")) {
return <Navigate to={`/@${username}/${workspaceName}`} />;
}
const [isConfirmingApply, setIsConfirmingApply] = useState(false);
const { mutate: updateWorkspace } = useMutation({
mutationFn: () =>
startWorkspace(workspace.id, workspace.template_active_version_id),
});

return (
<>
Expand All @@ -68,70 +84,99 @@ export const WorkspaceSchedulePage: FC = () => {
>
<PageHeaderTitle>Workspace Schedule</PageHeaderTitle>
</PageHeader>
{(scheduleState.hasTag("loading") || !template) && <Loader />}
{scheduleState.matches("error") && (
<ErrorAlert error={checkPermissionsError || getTemplateError} />
)}

{error && <ErrorAlert error={error} />}

{isLoading && <Loader />}

{permissions && !permissions.updateWorkspace && (
<Alert severity="error">
You don&apos;t have permissions to update the schedule for this
workspace.
</Alert>
)}
{template &&
workspace &&
(scheduleState.matches("presentForm") ||
scheduleState.matches("submittingSchedule")) && (
<WorkspaceScheduleForm
enableAutoStart={template.allow_user_autostart}
enableAutoStop={template.allow_user_autostop}
submitScheduleError={submitScheduleError}
initialValues={{
...getAutostart(workspace),
...getAutostop(workspace),
}}
isLoading={scheduleState.tags.has("loading")}
defaultTTL={dayjs.duration(template.default_ttl_ms, "ms").asHours()}
onCancel={() => {
navigate(`/@${username}/${workspaceName}`);
}}
onSubmit={async (values) => {
scheduleSend({
type: "SUBMIT_SCHEDULE",
autostart: formValuesToAutostartRequest(values),
ttl: formValuesToTTLRequest(values),
autostartChanged: scheduleChanged(
getAutostart(workspace),
values,
),
autostopChanged: scheduleChanged(
getAutostop(workspace),
values,
),
});

await queryClient.invalidateQueries(
workspaceByOwnerAndNameKey(params.username, params.workspace),
);
}}
/>
)}

{template && (
<WorkspaceScheduleForm
enableAutoStart={template.allow_user_autostart}
enableAutoStop={template.allow_user_autostop}
submitScheduleError={submitScheduleMutation.error}
initialValues={{
...getAutostart(workspace),
...getAutostop(workspace),
}}
isLoading={submitScheduleMutation.isLoading}
defaultTTL={dayjs.duration(template.default_ttl_ms, "ms").asHours()}
onCancel={() => {
navigate(`/@${username}/${workspaceName}`);
}}
onSubmit={async (values) => {
const data = {
workspace,
autostart: formValuesToAutostartRequest(values),
ttl: formValuesToTTLRequest(values),
autostartChanged: scheduleChanged(
getAutostart(workspace),
values,
),
autostopChanged: scheduleChanged(getAutostop(workspace), values),
};

await submitScheduleMutation.mutateAsync(data);

if (data.autostopChanged) {
setIsConfirmingApply(true);
}
}}
/>
)}

<ConfirmDialog
open={scheduleState.matches("showingRestartDialog")}
open={isConfirmingApply}
title="Restart workspace?"
description="Would you like to restart your workspace now to apply your new autostop setting, or let it apply after your next workspace start?"
confirmText="Restart"
cancelText="Apply later"
hideCancel={false}
onConfirm={() => {
scheduleSend("RESTART_WORKSPACE");
updateWorkspace();
navigate(`/@${username}/${workspaceName}`);
}}
onClose={() => {
scheduleSend("APPLY_LATER");
navigate(`/@${username}/${workspaceName}`);
}}
/>
</>
);
};

const getAutostart = (workspace: TypesGen.Workspace) =>
scheduleToAutostart(workspace.autostart_schedule);

const getAutostop = (workspace: TypesGen.Workspace) =>
ttlMsToAutostop(workspace.ttl_ms);

type SubmitScheduleData = {
workspace: TypesGen.Workspace;
autostart: TypesGen.UpdateWorkspaceAutostartRequest;
autostartChanged: boolean;
ttl: TypesGen.UpdateWorkspaceTTLRequest;
autostopChanged: boolean;
};

const submitSchedule = async (data: SubmitScheduleData) => {
const { autostartChanged, workspace, autostart, autostopChanged, ttl } = data;
const actions: Promise<void>[] = [];

if (autostartChanged) {
actions.push(putWorkspaceAutostart(workspace.id, autostart));
}

if (autostopChanged) {
actions.push(putWorkspaceAutostop(workspace.id, ttl));
}

return Promise.all(actions);
};

export default WorkspaceSchedulePage;
Loading